Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2.4] fix(Sharing): Do not create new share in guest app #1190

Closed
wants to merge 2 commits into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jun 24, 2024

Backport of PR #1189

Only create the template for share and return the the 'Sharing UI'
in the sidebar.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@backportbot backportbot bot requested review from artonge and Fenn-CS June 24, 2024 17:13
@backportbot backportbot bot added the 3. to review Waiting for reviews label Jun 24, 2024
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to backport this far?
stable2.4 is support 26 max

import { generateOcsUrl } from '@nextcloud/router'
import { Type as ShareTypes } from '@nextcloud/sharing'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need some adaptation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artonge no, assumed this was cover 27

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Jun 25, 2024

Backport should end at 27.

@Fenn-CS Fenn-CS closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants